-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-3887] Run Schedules - UX cleanup #2577
[RHOAIENG-3887] Run Schedules - UX cleanup #2577
Conversation
e14555a
to
6e06152
Compare
d4d2adc
to
790d427
Compare
790d427
to
c55695f
Compare
Can you add tests for the redirect like how juntao did in his latest PR: it('navigate to create run page from pipeline row', () => {
...
pipelinesTable.findRowByName(initialMockPipeline.display_name).findByText('Create run').click();
verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/create`);
}); |
frontend/src/concepts/pipelines/content/createRun/contentSections/RunTypeSection.tsx
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/createRun/contentSections/RunTypeSection.tsx
Outdated
Show resolved
Hide resolved
c55695f
to
022ddbf
Compare
Added these tests in latest commit. |
022ddbf
to
1237aa0
Compare
@Gkrumbach07 Ah, probably a consequence of some of the recent route changes from upstream. I'll take a look, thanks. |
FWIW, "View runs" wasn't a part of this PR, so this is a bug that already exists, but I'm still looking into it. |
30dd2bc
to
b5e5d72
Compare
This looks good, once tests pass we should merge |
b5e5d72
to
3e2b8ac
Compare
Sweet tests pass, and the view runs bug has been fixed. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-3887
Description
Added actions to the pipelines list, pipeline version details, wrapped Schedule settings in a form section for the Create/Schedule run page so that it can be jumped to.
Create run alert
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/d0404281-a77a-42c3-9d22-7acc680a4181
Create schedule alert
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/e07ab74a-9ded-4f93-9cfb-d317a5457f01
Pipeline version detail actions
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/5731087e-a970-4070-b133-1522b7404aac
Pipeline list actions
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/96fbdca8-b1a8-4e5a-96a5-db76c17ebddf
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/6eb52b23-a022-480e-bd94-0e2314bad952
How to test
The videos above represent how one would test these changes. cc @yannnz
How Has This Been Tested?
Mostly manual testing, added some unit tests
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main