Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-3887] Run Schedules - UX cleanup #2577

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Mar 8, 2024

Closes: RHOAIENG-3887

Description

Added actions to the pipelines list, pipeline version details, wrapped Schedule settings in a form section for the Create/Schedule run page so that it can be jumped to.

Create run alert
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/d0404281-a77a-42c3-9d22-7acc680a4181

Create schedule alert
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/e07ab74a-9ded-4f93-9cfb-d317a5457f01

Pipeline version detail actions
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/5731087e-a970-4070-b133-1522b7404aac

Pipeline list actions
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/96fbdca8-b1a8-4e5a-96a5-db76c17ebddf
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/6eb52b23-a022-480e-bd94-0e2314bad952

How to test

The videos above represent how one would test these changes. cc @yannnz

How Has This Been Tested?

Mostly manual testing, added some unit tests

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-3887-ux-schedule-changes branch from e14555a to 6e06152 Compare March 8, 2024 16:32
@jpuzz0 jpuzz0 changed the title RHOAIENG-3887-ux-schedule-changes [RHOAIENG-3887] Run Schedules - UX cleanup Mar 8, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-3887-ux-schedule-changes branch 2 times, most recently from d4d2adc to 790d427 Compare March 8, 2024 21:34
@jpuzz0 jpuzz0 changed the base branch from f/pipelines-v2 to main March 11, 2024 18:10
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Mar 11, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-3887-ux-schedule-changes branch from 790d427 to c55695f Compare March 11, 2024 18:13
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Mar 11, 2024
@Gkrumbach07
Copy link
Member

Can you add tests for the redirect like how juntao did in his latest PR:

it('navigate to create run page from pipeline row', () => {
     ...
    pipelinesTable.findRowByName(initialMockPipeline.display_name).findByText('Create run').click();
    verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/create`);
  });

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-3887-ux-schedule-changes branch from c55695f to 022ddbf Compare March 12, 2024 12:59
@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Mar 12, 2024

Can you add tests for the redirect like how juntao did in his latest PR:

it('navigate to create run page from pipeline row', () => {
     ...
    pipelinesTable.findRowByName(initialMockPipeline.display_name).findByText('Create run').click();
    verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/create`);
  });

Added these tests in latest commit.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-3887-ux-schedule-changes branch from 022ddbf to 1237aa0 Compare March 12, 2024 14:22
@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Mar 13, 2024

wait also found something else here
image
view runs for the version row does not apply the filter

edit: this also happens from the pipeline details screen too

@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Mar 13, 2024

wait also found something else here image view runs for the version row does not apply the filter

edit: this also happens from the pipeline details screen too

@Gkrumbach07 Ah, probably a consequence of some of the recent route changes from upstream. I'll take a look, thanks.

@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Mar 14, 2024

wait also found something else here image view runs for the version row does not apply the filter
edit: this also happens from the pipeline details screen too

@Gkrumbach07 Ah, probably a consequence of some of the recent route changes from upstream. I'll take a look, thanks.

FWIW, "View runs" wasn't a part of this PR, so this is a bug that already exists, but I'm still looking into it.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-3887-ux-schedule-changes branch 3 times, most recently from 30dd2bc to b5e5d72 Compare March 14, 2024 15:00
@Gkrumbach07
Copy link
Member

This looks good, once tests pass we should merge

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-3887-ux-schedule-changes branch from b5e5d72 to 3e2b8ac Compare March 14, 2024 17:37
@Gkrumbach07
Copy link
Member

Sweet tests pass, and the view runs bug has been fixed.
/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8457135 into opendatahub-io:main Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants