-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-2985] Experiments - Run Integration #2601
[RHOAIENG-2985] Experiments - Run Integration #2601
Conversation
70944d9
to
e33b641
Compare
3a823aa
to
7ef9dfb
Compare
frontend/src/pages/pipelines/GlobalPipelineExperimentsRoutes.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/pipelines/global/runs/ExperimentRunsBreadcrumb.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/pipelines/global/runs/ExperimentRunsBreadcrumb.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableRow.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments
frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableRow.tsx
Show resolved
Hide resolved
frontend/src/pages/pipelines/global/runs/ExperimentRunsBreadcrumb.tsx
Outdated
Show resolved
Hide resolved
7ef9dfb
to
f3acc9f
Compare
f3acc9f
to
d7e0468
Compare
d7e0468
to
7f8fc2c
Compare
7f8fc2c
to
800f87a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
going to test it live quick then we can merge
/approve everything works as expected and ux was tagged |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-2985
Description
Added experiment related routes, helpers for those routes which resemble recently added route helpers for pipelines/versions/runs. The experiment helpers are used to build breadcrumbs which are conditionally used for runs pages based on the experiment feature flag and the existence of an experimentId in the URL.
Clicking on an experiment's now linked name from the experiments table should yield the runs tables/tabs where the "Active" is initially selected, where the results of the runs for each table (active/archive/schedules) are filtered by the chosen experiment's ID.
Since results are scoped to the experiment ID, the
Experiment
column and filter are hidden from the user and only shown if runs are accessed by other means (not via an experiment).Screenshots (demonstrating breadcrumbs)
Runs table/tabs
Create run
Schedule run
Duplicate run
Duplicate schedule
Run details
Schedule details
cc @yannnz
How Has This Been Tested?
Added a few tests accessing runs from the experiments page and accessing breadcrumbs from experiment-scoped run pages.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main