Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-2985] Experiments - Run Integration #2601

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Mar 14, 2024

Closes: RHOAIENG-2985

Description

Added experiment related routes, helpers for those routes which resemble recently added route helpers for pipelines/versions/runs. The experiment helpers are used to build breadcrumbs which are conditionally used for runs pages based on the experiment feature flag and the existence of an experimentId in the URL.

Clicking on an experiment's now linked name from the experiments table should yield the runs tables/tabs where the "Active" is initially selected, where the results of the runs for each table (active/archive/schedules) are filtered by the chosen experiment's ID.

Since results are scoped to the experiment ID, the Experiment column and filter are hidden from the user and only shown if runs are accessed by other means (not via an experiment).

Screenshots (demonstrating breadcrumbs)

Runs table/tabs
image

Create run
image

Schedule run
image

Duplicate run
image

Duplicate schedule
image

Run details
image

Schedule details
image

cc @yannnz

How Has This Been Tested?

Added a few tests accessing runs from the experiments page and accessing breadcrumbs from experiment-scoped run pages.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Mar 14, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2985-experiments-run-integration branch from 70944d9 to e33b641 Compare March 14, 2024 21:10
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Mar 14, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2985-experiments-run-integration branch 10 times, most recently from 3a823aa to 7ef9dfb Compare March 18, 2024 13:12
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2985-experiments-run-integration branch from 7ef9dfb to f3acc9f Compare March 19, 2024 20:26
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Mar 19, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2985-experiments-run-integration branch from f3acc9f to d7e0468 Compare March 19, 2024 20:28
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Mar 19, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2985-experiments-run-integration branch from d7e0468 to 7f8fc2c Compare March 19, 2024 20:58
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2985-experiments-run-integration branch from 7f8fc2c to 800f87a Compare March 19, 2024 21:08
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

going to test it live quick then we can merge

@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Mar 21, 2024

/approve

everything works as expected and ux was tagged

Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit db0fba3 into opendatahub-io:main Mar 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants