-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authorization to kserve #2625
Add authorization to kserve #2625
Conversation
/hold |
6ec1b0e
to
75a388d
Compare
/retest |
93a6911
to
9d263f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed it, reviewed the Area stuff -- needs a more contextual review and testing.
@vconzola Can you check the screenshots to make sure everything is right here? |
frontend/src/concepts/areas/__tests__/useFetchDsciStatus.spec.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/global/InferenceServiceListView.tsx
Outdated
Show resolved
Hide resolved
...nd/src/pages/modelServing/screens/projects/ServingRuntimeModal/AuthServingRuntimeSection.tsx
Outdated
Show resolved
Hide resolved
...d/src/pages/modelServing/screens/projects/ServingRuntimeModal/ServingRuntimeTokenSection.tsx
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/projects/kServeModal/ManageKServeModal.tsx
Outdated
Show resolved
Hide resolved
Tested various scenarios with @lucferbux /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes https://issues.redhat.com/browse/RHOAIENG-2223
Description
Add the following changes:
Add section to enable route protection in kserve
New token section in kserve deployments
Check of Authorino availability to enable/disable the feature in kserve
How Has This Been Tested?
Local environment
backend/src/utils/dsci.ts
and add the following code in line 15Code
(note: you should add the feature flag and the crd with oc apply)
Test Impact
Testing added
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main