-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-4226] Add additional tracking for projects UI. #2628
Conversation
Hi @pilhuhn. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Also, @pilhuhn is there any jira issue to link to the PR? |
See PR title :) RHOAIENG-4226 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I've tested the events and they are working just fine, I'm gonna approve it, my only concern is wethere this raw events are well categorized in segment, I haven't tried that
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This adds additional Segment tracking. No visible UI changes are done.
This is recorded in https://issues.redhat.com/browse/RHOAIENG-4226
How Has This Been Tested?
Click through projects UI, see events flow into Segment (or in dev-mode, watch browser console)
Test Impact
UI behaviour is not changed.
Request review criteria:
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main