Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-4226] Add additional tracking for projects UI. #2628

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

pilhuhn
Copy link
Contributor

@pilhuhn pilhuhn commented Mar 25, 2024

Description

This adds additional Segment tracking. No visible UI changes are done.
This is recorded in https://issues.redhat.com/browse/RHOAIENG-4226

How Has This Been Tested?

Click through projects UI, see events flow into Segment (or in dev-mode, watch browser console)

Test Impact

UI behaviour is not changed.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

Hi @pilhuhn. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Mar 25, 2024
@andrewballantyne
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Mar 25, 2024
@dgutride dgutride added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label Apr 4, 2024
@lucferbux
Copy link
Contributor

Also, @pilhuhn is there any jira issue to link to the PR?

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 5, 2024
@pilhuhn
Copy link
Contributor Author

pilhuhn commented Apr 8, 2024

Also, @pilhuhn is there any jira issue to link to the PR?

See PR title :) RHOAIENG-4226

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I've tested the events and they are working just fine, I'm gonna approve it, my only concern is wethere this raw events are well categorized in segment, I haven't tried that

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andrewballantyne,lucferbux]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a453ed9 into opendatahub-io:main Apr 8, 2024
6 checks passed
@pilhuhn pilhuhn deleted the tracking2 branch April 15, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ds-projects-rework lgtm ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants