-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PipelineRuns Cypress test to account for sorting and filtering #2642
Merged
openshift-merge-bot
merged 1 commit into
opendatahub-io:main
from
ashley-o0o:cypress/PipelineCreateRuns3819
Apr 5, 2024
Merged
Update PipelineRuns Cypress test to account for sorting and filtering #2642
openshift-merge-bot
merged 1 commit into
opendatahub-io:main
from
ashley-o0o:cypress/PipelineCreateRuns3819
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashley-o0o
force-pushed
the
cypress/PipelineCreateRuns3819
branch
from
March 27, 2024 17:36
9544bbe
to
6921189
Compare
ashley-o0o
force-pushed
the
cypress/PipelineCreateRuns3819
branch
4 times, most recently
from
March 28, 2024 15:20
4cc7ba2
to
7980c9c
Compare
pnaik1
requested changes
Apr 1, 2024
frontend/src/__tests__/cypress/cypress/e2e/pipelines/PipelineRuns.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/pipelines/PipelineRuns.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/pipelines/PipelineRuns.cy.ts
Outdated
Show resolved
Hide resolved
ashley-o0o
force-pushed
the
cypress/PipelineCreateRuns3819
branch
3 times, most recently
from
April 3, 2024 14:23
221d27a
to
1fe2b50
Compare
ashley-o0o
force-pushed
the
cypress/PipelineCreateRuns3819
branch
from
April 3, 2024 16:39
1fe2b50
to
b63b07d
Compare
ashley-o0o
force-pushed
the
cypress/PipelineCreateRuns3819
branch
from
April 3, 2024 16:40
b63b07d
to
3b510cd
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: RHOAIENG-3819
Description
This PR validates that the Archived runs table filtering, searching and sorting functionality works properly, and that the Active and Scheduled runs table sorting functionality works.
How Has This Been Tested?
npm run test
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main