Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make content updates for project UI screens #2649

Merged

Conversation

thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Mar 29, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-4978
Closes: RHOAIENG-4846

Description

Updates to project UI screens were required per a content updates Google doc linked in the ticket above

How Has This Been Tested?

Ran unit and cypress tests locally, also visually when running the dashboard locally

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Mar 29, 2024
Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

Hi @thatblindgeye. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Mar 29, 2024
@thatblindgeye thatblindgeye marked this pull request as ready for review April 1, 2024 13:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Apr 1, 2024
@manaswinidas
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Apr 1, 2024
@thatblindgeye
Copy link
Contributor Author

@simrandhaliw just FYI in case you would like to check the content updates

@simrandhaliw
Copy link

Tagging @jgiardino in this PR in case she'd like to review the content updates too.

@thatblindgeye thatblindgeye force-pushed the 4978_projectUIContent branch 3 times, most recently from 2b71619 to d2389d3 Compare April 4, 2024 12:27
@dgutride dgutride added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label Apr 4, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 4, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase PR needs to be rebased and removed needs-rebase PR needs to be rebased labels Apr 4, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Apr 5, 2024
@jgiardino
Copy link

I reviewed contents in the latest poc where possible. For contents I couldn't check in the POC, I was able to check if they were present in this PR.

I left comments inline regarding a few cases that don't match what I expected. But there is one use case that I couldn't see any contents for in this PR related to the models empty state when both serving platforms are enabled.

@thatblindgeye thatblindgeye force-pushed the 4978_projectUIContent branch 2 times, most recently from 3677926 to b3e1290 Compare April 5, 2024 18:12
@jgiardino
Copy link

Everything seems to be good. I think the updated logic for the pipelines card looks good but I can’t really confirm without seeing the UI. 😉

Thank you for making these updates!!!

Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Make content updates for Project UI screen

Make content updates for Project UI screens

Make content updates for project UI screens

Additional updates

Add empty state for both platforms not enabled

Update verbiage for data connections emptystate

Updated multimodel verbiage for serve section

Remove unneccessary logicals

Conditionally render deploy model button in toolbar

Fix verbiage

Update based on missing update comments in document

Remove unnecessary key prop

Revert to use Alert component
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-phillips-18, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5f67d22 into opendatahub-io:main Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ds-projects-rework lgtm ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants