Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-4859] Fix for showing correct models in project overview #2661

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes RHOAIENG-4859

Description

Fixes an issue where models from all projects are being shown in the models section of the overview page. The fix is to pass the project name to the models list rather than incorrectly using the current project namespace field.

How Has This Been Tested?

Manually tested and verified that models from other projects no longer show in the cards list.

Test Impact

None.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)

@dgutride dgutride added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label Apr 4, 2024
@christianvogt
Copy link
Contributor

@jeff-phillips-18 please rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 4, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

requires rebase

Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 4, 2024
@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7fc701a into opendatahub-io:main Apr 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ds-projects-rework lgtm priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants