-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-4980] Fix RBAC on every tab for the action button #2662
[RHOAIENG-4980] Fix RBAC on every tab for the action button #2662
Conversation
d59756c
to
87c9d24
Compare
87c9d24
to
5f4e8e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this with an edit user? The Permissions tab should not be visible to those users.
5f4e8e4
to
cdbdf7a
Compare
@andrewballantyne Rebase and added check before showing the permissions card. |
@jeff-phillips-18 Logged in as a self-provisioner user who was granted |
cdbdf7a
to
4c6fb03
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-4980
Description
Remove erroneous RBAC checks
How Has This Been Tested?
Logged in as non-admin, verified I could create necessary items.
Test Impact
None
Request review criteria: