Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-4980] Fix RBAC on every tab for the action button #2662

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes: RHOAIENG-4980

Description

Remove erroneous RBAC checks

How Has This Been Tested?

Logged in as non-admin, verified I could create necessary items.

Test Impact

None

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)

@dgutride dgutride added ds-projects-rework priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. labels Apr 3, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 4, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Apr 5, 2024
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this with an edit user? The Permissions tab should not be visible to those users.

@jeff-phillips-18
Copy link
Contributor Author

@andrewballantyne Rebase and added check before showing the permissions card.

@christianvogt
Copy link
Contributor

@jeff-phillips-18 Logged in as a self-provisioner user who was granted edit access to a project and I still see the permissions tab as well as permissions card:
image

image

@christianvogt
Copy link
Contributor

There's also this issue when trusty isn't disabled even though it should be. Maybe related to how tabs are being enabled and the permissions tab issue.
image

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9c487bb into opendatahub-io:main Apr 9, 2024
6 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the RHOAIENG-4980 branch April 9, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ds-projects-rework lgtm priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants