Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-4996] Show popover help for non-empty pipelines/notebooks cards #2665

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes: RHOAIENG-4996

Description

Remove the help popovers for the Project overview, workbench and pipeline empty state cards.
Add the help popovers for the Project overview, workbench and pipeline non-empty state cards.

How Has This Been Tested?

Tested against projects with and without workbenches and pipelines

Test Impact

None

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).

@openshift-ci openshift-ci bot requested review from dpanshug and ppadti April 3, 2024 16:49
@dgutride dgutride added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label Apr 4, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 34818b8 into opendatahub-io:main Apr 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ds-projects-rework lgtm priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants