Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(watson): Add new watson-x tiles and remove watson resources #2668

Merged

Conversation

dgutride
Copy link
Contributor

@dgutride dgutride commented Apr 3, 2024

Description

Add new documentation tile, application tile and a new 45 minute how-to tile as shown below.
Screenshot 2024-04-03 at 1 11 43 PM
Screenshot 2024-04-03 at 1 12 03 PM

Can be seen on this cluster with google creds: https://rhods-dashboard-redhat-ods-applications.apps.rosa.dg-cluster.937s.p3.openshiftapps.com/resources?provider=%5B%22IBM+watsonx.ai%22%5D

Closes: https://issues.redhat.com/browse/RHOAIENG-4447

How Has This Been Tested?

Applied yaml to cluster to ensure watson-x tiles (application and how-to) show up correctly and links work as expected.

Test Impact

Need to make sure new watson-x tiles are created and no old watson tiles are created in fresh install. Platform team is caring for removing them on upgrade, though.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@dgutride dgutride added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label Apr 4, 2024
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Resources look great!
Screenshot 2024-04-04 at 16 39 28

@zdtsw @VaishnaviHire FYI we are gonna merge this, i think the watson folder might need a deletion from your side, is that right?

Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 4, 2024
@zdtsw
Copy link
Member

zdtsw commented Apr 4, 2024

/lgtm

Resources look great! Screenshot 2024-04-04 at 16 39 28

@zdtsw @VaishnaviHire FYI we are gonna merge this, i think the watson folder might need a deletion from your side, is that right?

yes, some new one to add and the old one need to be cleanuped,
we have @ykaliuta assigned for this task already

Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

New changes are detected. LGTM label has been removed.

@dgutride dgutride force-pushed the add-watson-x-tiles branch 2 times, most recently from 9dad37d to 2387d7e Compare April 5, 2024 10:58
@lucferbux lucferbux added the lgtm label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fee2688 into opendatahub-io:main Apr 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants