-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compare runs list #2672
Merged
openshift-merge-bot
merged 1 commit into
opendatahub-io:main
from
DaoDaoNoCode:jira-rhoaieng-4658
Apr 5, 2024
Merged
Add compare runs list #2672
openshift-merge-bot
merged 1 commit into
opendatahub-io:main
from
DaoDaoNoCode:jira-rhoaieng-4658
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgutride
added
priority/high
Important issue that needs to be resolved asap. Releases should not have too many of these.
priority/normal
An issue with the product; fix when possible
and removed
priority/high
Important issue that needs to be resolved asap. Releases should not have too many of these.
labels
Apr 4, 2024
Gkrumbach07
reviewed
Apr 4, 2024
frontend/src/concepts/pipelines/content/compareRuns/CompareRunsRunList.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/compareRuns/CompareRunsRunList.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/compareRuns/CompareRunsRunList.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/compareRuns/CompareRunTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/compareRuns/CompareRunTableToolbar.tsx
Outdated
Show resolved
Hide resolved
DaoDaoNoCode
force-pushed
the
jira-rhoaieng-4658
branch
from
April 4, 2024 19:30
4a20776
to
8753bb8
Compare
Gkrumbach07
reviewed
Apr 4, 2024
frontend/src/concepts/pipelines/content/compareRuns/CompareRunTableRow.tsx
Outdated
Show resolved
Hide resolved
DaoDaoNoCode
force-pushed
the
jira-rhoaieng-4658
branch
from
April 4, 2024 20:21
8753bb8
to
05c1722
Compare
Gkrumbach07
reviewed
Apr 5, 2024
frontend/src/concepts/pipelines/content/compareRuns/CompareRunsRunList.tsx
Outdated
Show resolved
Hide resolved
DaoDaoNoCode
force-pushed
the
jira-rhoaieng-4658
branch
from
April 5, 2024 17:33
05c1722
to
4d97a44
Compare
works well thanks /lgtm |
Gkrumbach07
approved these changes
Apr 5, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: RHOAIENG-4658
Description
Added an expandable list to show the runs that are being compared.
Finish the filter as well.
How Has This Been Tested?
Compare runs
buttonTest Impact
Add some check to the cypress e2e test to make sure it can correctly render the list.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main