Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compare runs list #2672

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Apr 3, 2024

JIRA: RHOAIENG-4658

Description

Added an expandable list to show the runs that are being compared.
Screenshot 2024-04-03 at 4 24 00 PM

Finish the filter as well.
Screenshot 2024-04-03 at 4 25 45 PM

How Has This Been Tested?

  1. Go to the experiment page
  2. Go to experiment details
  3. Check some runs and click on Compare runs button
  4. You will see this page
  5. Test the sort and filter functions

Test Impact

Add some check to the cypress e2e test to make sure it can correctly render the list.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested a review from dpanshug April 3, 2024 20:27
@dgutride dgutride added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. priority/normal An issue with the product; fix when possible and removed priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. labels Apr 4, 2024
@Gkrumbach07
Copy link
Member

works well thanks

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bc4388a into opendatahub-io:main Apr 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm priority/normal An issue with the product; fix when possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants