-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress test for permissions tab #2674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes, for test id's according to https://github.com/opendatahub-io/odh-dashboard/blob/main/docs/testing.md#selectors-and-test-ids
frontend/src/pages/projects/projectSharing/ProjectSharingPermissionSelection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/projectSharing/ProjectSharingTable.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/projectSharing/ProjectSharingTableSection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/projectSharing/ProjectSharingNameInput.tsx
Outdated
Show resolved
Hide resolved
/retest |
/retest |
a762545
to
d771d06
Compare
/lgtm |
frontend/src/pages/projects/projectSharing/ProjectSharingTableSection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/projectSharing/ProjectSharingNameInput.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/projectSharing/ProjectSharingPermissionSelection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/projectSharing/ProjectSharingTable.tsx
Outdated
Show resolved
Hide resolved
fa0bc5c
to
95d17dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
frontend/src/__tests__/cypress/cypress/e2e/projects/Permissions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/projects/Permissions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/projectSharing/ProjectSharingTableRowAdd.tsx
Outdated
Show resolved
Hide resolved
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, dpanshug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Closes: RHOAIENG-3807
Description
This PR aims to add cypress test for Permissions tab.
How Has This Been Tested?
npm run test
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main