-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ModelServingGlobal Cypress test to account for sorting and filtering #2688
Merged
openshift-merge-bot
merged 1 commit into
opendatahub-io:main
from
ashley-o0o:cypress/ModelServingGlobal3837
Apr 12, 2024
Merged
Update ModelServingGlobal Cypress test to account for sorting and filtering #2688
openshift-merge-bot
merged 1 commit into
opendatahub-io:main
from
ashley-o0o:cypress/ModelServingGlobal3837
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashley-o0o
force-pushed
the
cypress/ModelServingGlobal3837
branch
from
April 8, 2024 15:46
4faa1ec
to
47ca74e
Compare
pnaik1
requested changes
Apr 10, 2024
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ModelServingGlobal.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ModelServingGlobal.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ModelServingGlobal.cy.ts
Outdated
Show resolved
Hide resolved
ashley-o0o
force-pushed
the
cypress/ModelServingGlobal3837
branch
from
April 10, 2024 14:29
47ca74e
to
1ea114e
Compare
ashley-o0o
force-pushed
the
cypress/ModelServingGlobal3837
branch
from
April 10, 2024 15:47
1ea114e
to
169b2dd
Compare
ppadti
reviewed
Apr 11, 2024
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ModelServingGlobal.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ModelServingGlobal.cy.ts
Outdated
Show resolved
Hide resolved
ashley-o0o
force-pushed
the
cypress/ModelServingGlobal3837
branch
from
April 11, 2024 17:19
169b2dd
to
481c746
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: RHOAIENG-3837
Description
This PR validates that the Name and Project table filtering, searching, and sorting functionality works properly
How Has This Been Tested?
npm run test
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main