Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DW: Use 1-2 decimal places for all GiB and memory values, or 3 places for tooltips #2691

Merged

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Apr 8, 2024

Addresses feedback related to RHOAIENG-2845, RHOAIENG-2848 and RHOAIENG-2844

Description

  • Consolidates previously redundant util functions used for unit conversion and rounding numbers
  • Standardizes the precision of numbers in Distributed Workloads views:
    • For numbers rendered directly on the page, 1 or 2 decimal places are used (2 decimal places for values under 0.1 so they are not rounded to 0, which is the existing behavior for storage capacity elsewhere in the dashboard).
    • For numbers rendered in tooltips, 3 decimal places are used. This is consistent with how precise numbers are shown in the OpenShift console.
  • Shows units for all numbers in tooltips, in case the tooltip covers up the unit displayed in the chart subtitle.
  • Also standardizes the props passed into CPU/Memory chart components with metricLabel and unitLabel props for consistency, and refactors the TopResourceConsumingWorkloadsChart to simplify how data is passed in.
Screenshot 2024-04-08 at 4 13 56 PM Screenshot 2024-04-08 at 4 14 03 PM

cc @xianli123 @cfullam1 @yannnz

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley
Copy link
Contributor Author

mturley commented Apr 10, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

New changes are detected. LGTM label has been removed.

@mturley mturley added the lgtm label Apr 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit aceb751 into opendatahub-io:main Apr 10, 2024
6 checks passed
@mturley mturley deleted the dw-number-precision branch April 10, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants