Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InvalidArgoDeploymentAlert component to AppRoutes #2701

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Apr 11, 2024

closes: https://issues.redhat.com/browse/RHOAIENG-5296

Description

Adds a alert to the top of every page that can be dismissed (and stays dismissed) when the following are true:

  • pipelines feature flag is enabled
  • there exists a condition with the following c.type === 'CapabilityDSPv2Argo' && c.status === 'False' in the DSC
Screenshot 2024-04-12 at 9 40 34 AM

How Has This Been Tested?

You can add this mocked data to backend/src/utils/dsc.ts

diff --git a/backend/src/utils/dsc.ts b/backend/src/utils/dsc.ts
index eae01bc1..a5a7e81d 100644
--- a/backend/src/utils/dsc.ts
+++ b/backend/src/utils/dsc.ts
@@ -12,6 +12,26 @@ export const getClusterStatus = async (
   const result: DataScienceClusterKind | null = await fastify.kube.customObjectsApi
     .listClusterCustomObject('datasciencecluster.opendatahub.io', 'v1', 'datascienceclusters')
     .then((res) => (res.body as DataScienceClusterList).items[0])
+    .then((dsc) => {
+      return {
+        ...dsc,
+        status: {
+          ...dsc.status,
+          conditions: [
+            ...dsc.status.conditions,
+            {
+              lastHeartbeatTime: '2024-04-03T19:11:09Z',
+              lastTransitionTime: '2024-04-03T19:10:27Z',
+              message: 'Argo Workflow CRD already exists but not deployed by this operator',
+              reason: 'ArgoWorkflowExist',
+              status: 'False',
+              type: 'CapabilityDSPv2Argo',
+            },
+          ],
+        },
+      };
+    })
+
     .catch((e) => {
       fastify.log.error(`Failure to fetch dsc: ${e.response.body}`);
       return null;

Then try running with pipeline feature flag enabled and disabled. with it enabled and the mocked data, you should see the alert

Test Impact

no tests added

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).
    @kywalker-rh

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@Gkrumbach07 Gkrumbach07 force-pushed the story/RHOAIENG-5296-invalid-argo-detection-on-dspv2-upgrade branch 2 times, most recently from 2911814 to 34e8546 Compare April 11, 2024 20:34
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, not the solution I had in mind but I see the value of having this kind of flexbility, just add some comments and it will be ready to go

frontend/src/concepts/areas/types.ts Show resolved Hide resolved
@yannnz
Copy link

yannnz commented Apr 12, 2024

The name of "View details" should be "View documentation"

@jgarciao
Copy link

Beware this PR closes https://issues.redhat.com/browse/RHOAIENG-5296 (not https://issues.redhat.com/browse/RHOAIENG-4258) and that the product detected is Argo Workflows (with an s at the end)

@Gkrumbach07 Gkrumbach07 force-pushed the story/RHOAIENG-5296-invalid-argo-detection-on-dspv2-upgrade branch from 34e8546 to 1eacc94 Compare April 12, 2024 14:42
@kywalker-rh
Copy link

@Gkrumbach07 Based on @jgarciao comment above, can you update "Argo Workflow" to be "Argo Workflows"?

Otherwise this looks good to me.

Update link text in InvalidArgoDeploymentAlert component

Update INVALID_ARGO_DEPLOYMENT_DOCUMENTATION_URL

Add custom condition function and update invalid Argo deployment alert links

Fix typo in Argo Workflows name
@Gkrumbach07 Gkrumbach07 force-pushed the story/RHOAIENG-5296-invalid-argo-detection-on-dspv2-upgrade branch from 1eacc94 to 816aa44 Compare April 12, 2024 14:55
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

changes proposed from UX are implemented

@openshift-ci openshift-ci bot added the lgtm label Apr 12, 2024
@lucferbux
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4e8f822 into opendatahub-io:main Apr 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants