-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InvalidArgoDeploymentAlert component to AppRoutes #2701
Add InvalidArgoDeploymentAlert component to AppRoutes #2701
Conversation
2911814
to
34e8546
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great, not the solution I had in mind but I see the value of having this kind of flexbility, just add some comments and it will be ready to go
The name of "View details" should be "View documentation" |
Beware this PR closes https://issues.redhat.com/browse/RHOAIENG-5296 (not https://issues.redhat.com/browse/RHOAIENG-4258) and that the product detected is Argo Workflows (with an s at the end) |
34e8546
to
1eacc94
Compare
@Gkrumbach07 Based on @jgarciao comment above, can you update "Argo Workflow" to be "Argo Workflows"? Otherwise this looks good to me. |
Update link text in InvalidArgoDeploymentAlert component Update INVALID_ARGO_DEPLOYMENT_DOCUMENTATION_URL Add custom condition function and update invalid Argo deployment alert links Fix typo in Argo Workflows name
1eacc94
to
816aa44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
changes proposed from UX are implemented
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes: https://issues.redhat.com/browse/RHOAIENG-5296
Description
Adds a alert to the top of every page that can be dismissed (and stays dismissed) when the following are true:
c.type === 'CapabilityDSPv2Argo' && c.status === 'False'
in the DSCHow Has This Been Tested?
You can add this mocked data to
backend/src/utils/dsc.ts
Then try running with pipeline feature flag enabled and disabled. with it enabled and the mocked data, you should see the alert
Test Impact
no tests added
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
@kywalker-rh
After the PR is posted & before it merges:
main