Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when selecting a pipeline without version on the clone run page #2703

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Apr 11, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-4258

Description

When switching to a pipeline that contains no versions in it, we always trigger the hook useUpdatePipelineFormData and set the version to the incorrect one. The solution is to add a check before setting it to make sure we are only doing this when setting the same pipeline but not switching to another.
Also, fix a small issue that could crash the page.

How Has This Been Tested?

  1. Create 2 pipelines (pipeline 1 and pipeline 2)
  2. Delete the version in pipeline 2, make sure there is no version in it
  3. Create a run using pipeline 1
  4. Duplicate this run, and switch the pipeline selection to pipeline 2
  5. Verify the version selector is disabled and showing "no versions available" in it

Test Impact

Add some conditions in the cypress test to verify the change works.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested live and works. low impact -- very nice. good stuff.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e120a40 into opendatahub-io:main Apr 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants