-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useUser hook to EnsureCompatiblePipelineServer component #2705
Add useUser hook to EnsureCompatiblePipelineServer component #2705
Conversation
@Gkrumbach07 Only thing I see is the link in the Admin flow text should be on the next line. Otherwise this looks good to me. |
5b783a2
to
d098dfb
Compare
@Gkrumbach07 Content for the Admin view needs update. Please refer the mock: https://www.figma.com/proto/tMBCWHdmsk5qx79shNbGME/Invalid-Argo-Detection?type=design&node-id=76-1007&t=Zo9TOAtKc0GZZVDo-1&scaling=scale-down-width&page-id=0%3A1&mode=design |
Will the notice be shown in all these pages?
|
Add paragraph tags to body text in EnsureCompatiblePipelineServer component Update pipeline rendering message
d098dfb
to
213873c
Compare
lgtm Approved from UX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes: https://issues.redhat.com/browse/RHOAIENG-5334
Description
adjusts text dependent on admin or not
How Has This Been Tested?
Test Impact
none
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
@kywalker-rh
After the PR is posted & before it merges:
main