-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registered model table follow-up and cypress testing #2707
Registered model table follow-up and cypress testing #2707
Conversation
In continuation of #2677 this PR completes cypress testing |
frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelRegistry.cy.ts
Outdated
Show resolved
Hide resolved
979b8a4
to
cbc1660
Compare
frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelRegistry.cy.ts
Outdated
Show resolved
Hide resolved
d7496eb
to
aa2754c
Compare
frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelRegistry.cy.ts
Outdated
Show resolved
Hide resolved
3ef803f
to
1836d92
Compare
1836d92
to
8b45155
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
574af0c
to
91807ca
Compare
frontend/src/pages/modelRegistry/screens/RegisteredModelOwner.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistry/screens/RegisteredModelTableRow.tsx
Outdated
Show resolved
Hide resolved
91807ca
to
6228a35
Compare
frontend/src/pages/modelRegistry/screens/RegisteredModelTableRow.tsx
Outdated
Show resolved
Hide resolved
6228a35
to
d9dbaa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, just a small nit, once we have that we should be ready to go.
frontend/src/pages/modelRegistry/screens/RegisteredModelLabels.tsx
Outdated
Show resolved
Hide resolved
d9dbaa6
to
6199aa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-2231 RHOAIENG-2232
Description
Added cypress testing and minor changes
How Has This Been Tested?
Move to Model registry section
Test Impact
Added cypress test for model registry
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main