Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cypress test for Notebook server tab #2742

Merged
merged 1 commit into from
May 2, 2024

Conversation

uidoyen
Copy link
Contributor

@uidoyen uidoyen commented Apr 24, 2024

Closes: RHOAIENG-3918

Description

This PR aims to add cypress test for Notebook server tab.

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@uidoyen uidoyen changed the base branch from main to 2.4.0-release April 24, 2024 12:24
@uidoyen uidoyen changed the base branch from 2.4.0-release to main April 24, 2024 12:24
@uidoyen uidoyen requested review from ppadti and pnaik1 April 24, 2024 12:25
@uidoyen uidoyen force-pushed the RHOAIENG-3918 branch 4 times, most recently from 82202a9 to 8f9bbef Compare April 25, 2024 13:59
@pnaik1
Copy link
Contributor

pnaik1 commented Apr 26, 2024

/retest

@pnaik1
Copy link
Contributor

pnaik1 commented Apr 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 29, 2024
@pnaik1
Copy link
Contributor

pnaik1 commented May 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 2, 2024
@Gkrumbach07
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 007a425 into opendatahub-io:main May 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants