Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dscinitializations resource to cluster-role.yaml and handle missing dsci status in ServingRuntimeList.cy.ts #2758

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

lucferbux
Copy link
Contributor

Closes https://issues.redhat.com/browse/RHOAIENG-6578

Description

Add permissions to fetch dsci by the dashboard serviceaccount and fixes a flaw in the area enablement util method that returned true if the dsci was missing.

How Has This Been Tested?

  1. Run the changes in a cluster with dsci but no permissions
  2. Use npm run start:dev:ext to get the deployed dashboard serviceaccount capabilities
  3. Check that the kserve auth feature should be disabled
  4. Now add the permissions to the cluster (see bellow)
  5. Check that the feature should be enabled

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main
    Tested with npm run start:dev:ext which sholud mimic this same behavior

@lucferbux lucferbux requested review from alexcreasy and removed request for DaoDaoNoCode and dpanshug April 29, 2024 16:23
@lucferbux lucferbux force-pushed the rhoaieng-6578 branch 2 times, most recently from 9f3e11e to 20c3aef Compare April 29, 2024 17:00
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucas tested with connecting to the Dashboard Pod and overriding permissions on cluster -- I'm approving code.

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 380134f into opendatahub-io:main Apr 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants