Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-6322] Use constants for colors on images in AI Flows #2763

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes: RHOAIENG-6322

Description

To ensure colors are synced between the images and card colors for borders and selection, use the some color constants for the images as used elsewhere.

How Has This Been Tested?

Manually

Test Impact

None

Screen shot

image

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Included any necessary screenshots or gifs if it was a UI change.
  • [x ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

/cc @jgiardino

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@jeff-phillips-18: GitHub didn't allow me to request PR reviews from the following users: jgiardino.

Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Closes: RHOAIENG-6322

Description

To ensure colors are synced between the images and card colors for borders and selection, use the some color constants for the images as used elsewhere.

How Has This Been Tested?

Manually

Test Impact

None

Screen shot

image

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Included any necessary screenshots or gifs if it was a UI change.
  • [x ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

/cc @jgiardino

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection. Nicely all organized.

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6809b4d into opendatahub-io:main Apr 30, 2024
6 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the landing-page-images branch April 30, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants