Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model version view #2774

Merged

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented May 3, 2024

Closes: RHOAIENG-2238

Description

View for model version detail page with version selector at top

Screenshot from 2024-05-03 15-21-10

image

Screencast.from.2024-05-03.17-39-27.webm

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@vconzola @yih-wang

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label May 3, 2024
@openshift-ci openshift-ci bot requested review from manaswinidas and ppadti May 3, 2024 11:50
@dpanshug dpanshug mentioned this pull request May 3, 2024
7 tasks
@dpanshug dpanshug requested review from mturley and lucferbux May 3, 2024 11:56
@dpanshug
Copy link
Contributor Author

dpanshug commented May 3, 2024

To be merged after #2770

@dpanshug dpanshug changed the title [WIP] Model version view Model version view May 3, 2024
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label May 3, 2024
@mturley mturley dismissed manaswinidas’s stale review May 3, 2024 16:01

Comments were resolved

@mturley mturley requested a review from Gkrumbach07 May 3, 2024 17:22
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only comments are once that will be covered in the future pr

/approve

Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 3, 2024
@mturley mturley removed the do-not-merge/work-in-progress This PR is in WIP state label May 3, 2024
@Gkrumbach07
Copy link
Member

/test ci/prow/images

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@Gkrumbach07: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test odh-dashboard-pr-image-mirror

Use /test all to run all jobs.

In response to this:

/test ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gkrumbach07
Copy link
Member

/test images

@Gkrumbach07
Copy link
Member

/test odh-dashboard-pr-image-mirror

@openshift-merge-bot openshift-merge-bot bot merged commit 339060a into opendatahub-io:main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants