[RHOAIENG-6647] Fix to show all artifacts in pipeline topology view #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-phillips-18
force-pushed
the
pipeline-fixes
branch
from
6a75f1d
to
3cc6840
Compare
jeff-phillips-18
force-pushed
the
pipeline-fixes
branch
from
3cc6840
to
2b34210
Compare
jenny-s51
approved these changes
May 7, 2024
There was a problem hiding this comment.
Tested in UI and walked through code updates with @jeff-phillips-18 this afternoon. LGTM.
DaoDaoNoCode
approved these changes
May 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07, jenny-s51 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: RHOAIENG-6647
Description
Artifacts with the same name created by different tasks were being thrown out due to duplicate IDs. Update the generation of the artifact nodes to create a unique ID for the artifact based on its parent task's ID.
Update the version of @patternfly/react-topology to 5.4.0-prerelease.1 to pickup a fix for correct placement of spacer nodes.
How Has This Been Tested?
Verified locally that the artifact nodes show up correctly with the correct dependencies.
Added a test for
usePipelineTaskTopologyto verify the correct number of nodes are returned.Screen shots
Before
After
Request review criteria: