Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-4825] Use execution input/output values as fallback for run node details #2787

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented May 8, 2024

Closes: RHOAIENG-4825

Description

Use execution data for run node Input/Output parameter details.

Pasted Graphic 2 (cc @yannnz)

How to test

Navigate to a run with nodes that have Input/Output parameters associated with that run. Open the side panel by choosing one of those nodes, verify the contents of Input or Output parameters show actual values instead of just parameter types (e.g. STRING, although types are still a fallback, so if no execution data is found for a given task key, types will be shown).

Test Impact

Unit tested with all possible types of input/output parameters with corresponding task execution values.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from Gkrumbach07 and pnaik1 May 8, 2024 14:12
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one thing last sec

@Gkrumbach07 Gkrumbach07 removed the lgtm label May 8, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-4825-input-output-mlmd-params branch from 1f6a438 to 15429f6 Compare May 9, 2024 08:11
@openshift-ci openshift-ci bot added the approved label May 9, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-4825-input-output-mlmd-params branch from 15429f6 to 7a59516 Compare May 9, 2024 08:13
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ee7e684 into opendatahub-io:main May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants