-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-4825] Use execution input/output values as fallback for run node details #2787
[RHOAIENG-4825] Use execution input/output values as fallback for run node details #2787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
...d/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/SelectedNodeInputOutputTab.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one thing last sec
1f6a438
to
15429f6
Compare
15429f6
to
7a59516
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-4825
Description
Use execution data for run node Input/Output parameter details.
(cc @yannnz)How to test
Navigate to a run with nodes that have Input/Output parameters associated with that run. Open the side panel by choosing one of those nodes, verify the contents of Input or Output parameters show actual values instead of just parameter types (e.g. STRING, although types are still a fallback, so if no execution data is found for a given task key, types will be shown).
Test Impact
Unit tested with all possible types of input/output parameters with corresponding task execution values.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main