Fix DEV_MODE import in mlmd service #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gkrumbach07
force-pushed
the
task/RHOAIENG-5443-switch-to-targeting-mlmd-oauth-port-and-remove-dev
branch
from
e38acfd
to
27a01be
Compare
|
/approve |
Gkrumbach07
force-pushed
the
task/RHOAIENG-5443-switch-to-targeting-mlmd-oauth-port-and-remove-dev
branch
from
27a01be
to
23fa251
Compare
Fix DEV_MODE import in mlmd service Remove DEV_MODE import in mlmd service Refactor mlmd service proxy configuration Update mlmd service proxy configuration Update mlmd service proxy configuration port to 10001
Gkrumbach07
force-pushed
the
task/RHOAIENG-5443-switch-to-targeting-mlmd-oauth-port-and-remove-dev
branch
from
02e73a1
to
601874e
Compare
|
/retest |
|
adding the LGTM label manually. Approved in slack by @jenny-s51 but she is OTO https://redhat-internal.slack.com/archives/C05U1Q749PV/p1715280499663399?thread_ts=1715256024.633149&cid=C05U1Q749PV |
jenny-s51
approved these changes
May 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, jenny-s51 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Gkrumbach07
commented
May 10, 2024
| @@ -7,7 +7,7 @@ FASTIFY_LOG_LEVEL=debug | |||
|
|
|||
| DSPA_NAME=dspa | |||
| METADATA_ENVOY_SERVICE_HOST=localhost | |||
| METADATA_ENVOY_SERVICE_PORT=9090 | |||
| METADATA_ENVOY_SERVICE_PORT=10001 | |||
There was a problem hiding this comment.
port forward will be different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://issues.redhat.com/browse/RHOAIENG-5443
Description
How Has This Been Tested?
n/a
Test Impact
n/a
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main