Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate codecov #2797

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented May 9, 2024

https://issues.redhat.com/browse/RHOAIENG-5313

Description

Updates the PR workflow to run code coverage and upload results to codecov.

Configured not to fail CI if the upload fails and there are no thresholds set currently for project or patch so the coverage should only be informational at this time.

A comment will be left by Codecov bot after the coverage results are uploaded.

Codecov yml is configured to include status checks for project and patch level comparisons. These don't show up here so I do not know if it's not working or it simply requires the config to first be merged to main.

How Has This Been Tested?

Inspected codecov results here: https://app.codecov.io/github/opendatahub-io/odh-dashboard

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label May 9, 2024
@openshift-ci openshift-ci bot requested review from DaoDaoNoCode and ppadti May 9, 2024 16:28
@christianvogt christianvogt force-pushed the codecov branch 2 times, most recently from a019be3 to 40eb7db Compare May 9, 2024 19:00
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@christianvogt christianvogt force-pushed the codecov branch 5 times, most recently from 2dacd9a to 58f4e08 Compare May 9, 2024 20:11
@christianvogt christianvogt changed the title [WIP] Codecov [WIP] integrate codecov May 9, 2024
@christianvogt christianvogt force-pushed the codecov branch 2 times, most recently from ce9c007 to 0796f53 Compare May 10, 2024 14:33
@christianvogt christianvogt changed the title [WIP] integrate codecov integrate codecov May 10, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label May 10, 2024
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f3927fd into opendatahub-io:main May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants