Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-7073] Fix for cancel on spawn a notebook server page #2807

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes: RHOAIENG-7073

Description

Cancel on the spawner page sends the user to / which, when the home page is enabled, is incorrect. It should send the user to '/enabled' when the home page is enabled.

How Has This Been Tested?

Tested locally and added an e2e test.

Test Impact

Should test cancel from the spawner page with and without the home page enabled.

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@f3927fd). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2807   +/-   ##
=======================================
  Coverage        ?   77.25%           
=======================================
  Files           ?     1072           
  Lines           ?    22418           
  Branches        ?     5667           
=======================================
  Hits            ?    17319           
  Misses          ?     5099           
  Partials        ?        0           
Files Coverage Δ
.../notebookController/screens/server/SpawnerPage.tsx 60.92% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3927fd...de6d2c1. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 97b878a into opendatahub-io:main May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants