Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-6641] Backport 2.9 SSRF fixes to 2.8.x #2814

Merged

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented May 14, 2024

Closes: RHOAIENG-6641

Description

  • Removes proxy API from backend and backports service API from 2.9
  • Updates Pipelines and TrustyAI features to use new API
  • Updates cypress and unit tests

How Has This Been Tested?

Run on a cluster deployed with ODH 2.8.x zstream release.

  • Verify Pipelines features are not broken
  • Verify Bias features are not broken
  • Smoke test the rest of the dashboard to ensure no breakages

Test Impact

  • Existing tests updated to work with back ported APIs

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@christianvogt
Copy link
Contributor

Tested on a cluster setup by Alex. Ensured that both pipelines and trusty requests went to the new /api/service/* paths. Tested various pipeline actions including uploading a file.

/lgtm

Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3bf5da1 into opendatahub-io:v2.21.0-fixes May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants