-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pipeline version multi-select issue #2817
Fix pipeline version multi-select issue #2817
Conversation
...nd/src/concepts/pipelines/content/tables/pipelineVersion/usePipelineVersionsCheckboxTable.ts
Show resolved
Hide resolved
4d6f5dc
to
b4b1b2f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
- Coverage 78.14% 77.30% -0.85%
==========================================
Files 1076 1097 +21
Lines 22629 23083 +454
Branches 5722 5814 +92
==========================================
+ Hits 17684 17844 +160
- Misses 4945 5239 +294
... and 47 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments. Otherwise, this looks good.
frontend/src/__tests__/cypress/cypress/pages/pipelines/pipelinesTable.ts
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/pages/pipelines/pipelinesTable.ts
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTableRow.tsx
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/tables/pipelineVersion/PipelineVersionTableRow.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, jpuzz0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: https://issues.redhat.com/browse/RHOAIENG-7077
Description
It's a one-liner fix, we read the wrong property in the object of a pipeline version to select the checkbox.
However, I updated a lot of the pipeline cypress test to make it make more sense. Thanks for the help of @christianvogt
How Has This Been Tested?
Test Impact
Updated the cypress test.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main