-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edited manifest to remove dot #2826
Conversation
Skipping CI for Draft Pull Request. |
/test all |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2826 +/- ##
==========================================
+ Coverage 77.42% 77.48% +0.05%
==========================================
Files 1101 1110 +9
Lines 23165 23482 +317
Branches 5839 5917 +78
==========================================
+ Hits 17936 18195 +259
- Misses 5229 5287 +58 see 74 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RHOAIENG-1138
Description
I removed the dot at the end of "Deploying a sample Python application using Flask and OpenShift."
How Has This Been Tested?
Ran
npm run test:cypress-ci -- --spec "**/Resources.cy.ts"
.I also did manual testing, by running
oc apply -n opendatahub -f ./manifests/apps/jupyter/deploy-python-model-quickstart.yaml
Test Impact
I edited the mock corresponding to the manifest.
Request review criteria:
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main