Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edited manifest to remove dot #2826

Merged
merged 1 commit into from
May 29, 2024

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented May 20, 2024

RHOAIENG-1138

Description

I removed the dot at the end of "Deploying a sample Python application using Flask and OpenShift."

Screenshot 2024-05-21 at 11 29 37 AM

How Has This Been Tested?

Ran npm run test:cypress-ci -- --spec "**/Resources.cy.ts".

I also did manual testing, by running oc apply -n opendatahub -f ./manifests/apps/jupyter/deploy-python-model-quickstart.yaml

Test Impact

I edited the mock corresponding to the manifest.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label May 20, 2024
Copy link
Contributor

openshift-ci bot commented May 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rsun19
Copy link
Contributor Author

rsun19 commented May 20, 2024

/test all

@rsun19 rsun19 marked this pull request as ready for review May 21, 2024 15:34
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label May 21, 2024
@openshift-ci openshift-ci bot requested review from ppadti and uidoyen May 21, 2024 15:34
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.48%. Comparing base (56910f3) to head (0950972).
Report is 53 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2826      +/-   ##
==========================================
+ Coverage   77.42%   77.48%   +0.05%     
==========================================
  Files        1101     1110       +9     
  Lines       23165    23482     +317     
  Branches     5839     5917      +78     
==========================================
+ Hits        17936    18195     +259     
- Misses       5229     5287      +58     

see 74 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56910f3...0950972. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 073cb0e into opendatahub-io:main May 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants