-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show special error state for ChunkLoadError #2834
show special error state for ChunkLoadError #2834
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2834 +/- ##
==========================================
+ Coverage 77.44% 77.48% +0.04%
==========================================
Files 1102 1103 +1
Lines 23206 23213 +7
Branches 5856 5857 +1
==========================================
+ Hits 17971 17986 +15
+ Misses 5235 5227 -8
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Might want to consider tests more so because this is a near impossible reproduce state in the app.
af2252e
to
c5b7433
Compare
Added unit tests. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-2690
Description
@ UX please suggest icon and text
The times in which this screen may be shown is very very small. A possible way to encounter this issue in production is to have the web app opened while the dashboard updates behind the scene. Then the user attempts to navigate the already opened application.
A
ChunkLoadError
is a special case that indicates a failure to load a build artifact. This generally occurs because the web page was opened on a previous version of the application and the build artifacts have changed on the server. It may also occur as a result of cache not getting the latest version although this case hasn't been proven in our environment where it's expected that we do not cache such files.Whenever a
ChunkLoadError
is detected, the best course of action for the user is to simply refresh the page. As such this change will provide the user with a clear action button for how to proceed. Furthermore in case the error persists for some reason, we give the option to display the error as is done with all other errors. Since it's a possibility that other errors may also be resolved by reloading the page, a general message and reload action is provided in the header of the standard error page. eg. if after an update, the endpoint of an action on longer exists and throws an error.Clicking the
Show error
button will display the standard error screen for data collection purposes:How Has This Been Tested?
Added unit tests.
This has been tested locally.
npm run build
npm run start:dev
localhost:4000
Explore
page.###.js
javascript file request. This is the chunk related to the explore page.frontend/public/###.js
to anything else. eg###.js.bak
localhost:4000
and then click on theExplore
page link.Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @andrewballantyne @kywalker-rh @kaedward @vconzola