Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-5244] Adjust jest config to transform all PatternFly packages #2848

Conversation

wise-king-sullyman
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman commented May 23, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-5244

Description

Slightly tweaks the Jest configuration to transform all PF packages rather than only react-icons at the top level of node_modules.

The current configuration somewhat recently caused a very difficult to debug issue during PatternFly release testing for our 5.3 release, and this issue is likely to reoccur in the future which could cause significant delays in updating the version of PatternFly used by odh-dashboard in an emergency situation.

How Has This Been Tested?

This change resolved the issue as discovered during the PF 5.3 release testing and passes your automated tests locally when I ran them.

Test Impact

This change will cause all PF packages to be transformed during test running if needed. The current tests passing verifies that things are still working properly.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label May 23, 2024
Copy link
Contributor

openshift-ci bot commented May 23, 2024

Hi @wise-king-sullyman. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christianvogt
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.41%. Comparing base (f957299) to head (ba1b1a9).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2848      +/-   ##
==========================================
- Coverage   77.42%   77.41%   -0.01%     
==========================================
  Files        1102     1102              
  Lines       23203    23203              
  Branches     5854     5854              
==========================================
- Hits        17965    17963       -2     
- Misses       5238     5240       +2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f957299...ba1b1a9. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented May 27, 2024

Tested locally, working fine
/lgtm

@christianvogt
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b0073d9 into opendatahub-io:main May 27, 2024
8 checks passed
@wise-king-sullyman wise-king-sullyman deleted the transform-all-pf-packages branch May 28, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants