-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-5244] Adjust jest config to transform all PatternFly packages #2848
[RHOAIENG-5244] Adjust jest config to transform all PatternFly packages #2848
Conversation
Hi @wise-king-sullyman. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2848 +/- ##
==========================================
- Coverage 77.42% 77.41% -0.01%
==========================================
Files 1102 1102
Lines 23203 23203
Branches 5854 5854
==========================================
- Hits 17965 17963 -2
- Misses 5238 5240 +2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Tested locally, working fine |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes https://issues.redhat.com/browse/RHOAIENG-5244
Description
Slightly tweaks the Jest configuration to transform all PF packages rather than only react-icons at the top level of node_modules.
The current configuration somewhat recently caused a very difficult to debug issue during PatternFly release testing for our 5.3 release, and this issue is likely to reoccur in the future which could cause significant delays in updating the version of PatternFly used by odh-dashboard in an emergency situation.
How Has This Been Tested?
This change resolved the issue as discovered during the PF 5.3 release testing and passes your automated tests locally when I ran them.
Test Impact
This change will cause all PF packages to be transformed during test running if needed. The current tests passing verifies that things are still working properly.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main