-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert templates to use websocket #2855
Convert templates to use websocket #2855
Conversation
6b9b882
to
1b676b9
Compare
1b676b9
to
e5444a0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2855 +/- ##
==========================================
+ Coverage 78.16% 78.49% +0.33%
==========================================
Files 1101 1127 +26
Lines 23421 23944 +523
Branches 5902 6042 +140
==========================================
+ Hits 18307 18795 +488
- Misses 5114 5149 +35
... and 117 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@christianvogt I tried sending resource to websocket while editing serving templates in cypress test it doesn't seems to work. But I am unsure what should be the
|
frontend/src/__tests__/cypress/cypress/e2e/customServingRuntimes/CustomServingRuntimes.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/projects/ModelServingPlatform.tsx
Outdated
Show resolved
Hide resolved
3445807
to
95c1862
Compare
frontend/src/pages/modelServing/screens/projects/ModelServingPlatform.tsx
Outdated
Show resolved
Hide resolved
95c1862
to
02fa8ce
Compare
02fa8ce
to
c0c1cb7
Compare
frontend/src/pages/modelServing/customServingRuntimes/CustomServingRuntimeContext.tsx
Outdated
Show resolved
Hide resolved
63bfb64
to
165d5f5
Compare
165d5f5
to
44f19ac
Compare
Updated the PR. |
frontend/src/utilities/__tests__/useCustomK8sWatchResource.spec.ts
Outdated
Show resolved
Hide resolved
44f19ac
to
5809273
Compare
5809273
to
c43dfcd
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-5368
Description
Convert templates to use websockets. Replaces templates#listTemplates with useTemplates.
Created hook
useCustomK8sWatchResource
to perform type check on errors.How Has This Been Tested?
In settings, open serving runtimes:
Test Impact
Added unit test to the
useCustomK8sWatchResource
hook.Updated unit and cypress test to use websocket.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main