Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed active and archived pipeline experiment table to compact #2868

Merged
merged 1 commit into from
May 31, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented May 31, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-7125

Description

Active and archived Pipeline experiment table compact
Before changes:

Screenshot from 2024-05-31 19-03-48

After changes:

Screenshot from 2024-05-31 19-04-32

How Has This Been Tested?

  1. Enable experiment flag from odhDashboardConfig
  2. Go to the Experiment Page
  3. Check whether the acyive and archived experiment table is compact

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.43%. Comparing base (4aa0a8c) to head (6af7e6e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2868      +/-   ##
==========================================
- Coverage   77.46%   77.43%   -0.03%     
==========================================
  Files        1110     1110              
  Lines       23515    23515              
  Branches     5932     5932              
==========================================
- Hits        18215    18210       -5     
- Misses       5300     5305       +5     
Files Coverage Δ
.../content/tables/experiment/ExperimentTableBase.tsx 81.48% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa0a8c...6af7e6e. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3bee930 into opendatahub-io:main May 31, 2024
8 checks passed
@pnaik1 pnaik1 deleted the RHOAIENG-7125 branch July 22, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants