-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added method-style rule for eslint #2869
added method-style rule for eslint #2869
Conversation
c2a8b28
to
3494a67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2869 +/- ##
=======================================
Coverage 78.14% 78.15%
=======================================
Files 1101 1101
Lines 23421 23421
Branches 5902 5902
=======================================
+ Hits 18303 18305 +2
+ Misses 5118 5116 -2 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
frontend/src/__tests__/cypress/cypress/support/commands/application.ts
Outdated
Show resolved
Hide resolved
3494a67
to
4aa0a8c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, gitdallas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
be332ac
to
5e0d880
Compare
Sorry, resolved merge conflicts |
/lgtm |
Closes: RHOAIENG-4721
Description
Set this eslint rule:
"@typescript-eslint/method-signature-style": "error"
to have consistency for interface functions. The standard we're trying to achieve isfunc: (arg: type) => type;
details: https://issues.redhat.com/browse/RHOAIENG-4721
How Has This Been Tested?
npm run test:lint
Request review criteria:
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main