Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix info popover for pipeline overview card #2871

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-6654

Description

Removed logic that attempted to show the info icon + tooltip under certain conditions. Instead, as per UX guidance, always show the the icon + tooltip.

image

image

How Has This Been Tested?

  • Create a project
  • add a pipeline server
  • go to the project details and observe the info popover is present
  • add a pipeline
  • go to the project details and observe the info popover is present

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @jgiardino

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.45%. Comparing base (3bee930) to head (104bcb8).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2871      +/-   ##
==========================================
+ Coverage   77.44%   77.45%   +0.01%     
==========================================
  Files        1110     1110              
  Lines       23521    23518       -3     
  Branches     5937     5934       -3     
==========================================
+ Hits        18215    18217       +2     
+ Misses       5306     5301       -5     
Files Coverage Δ
...ail/overview/trainModels/PipelinesOverviewCard.tsx 83.33% <ø> (+5.55%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bee930...104bcb8. Read the comment docs.

@jgiardino
Copy link

Thanks for making this update! LGTM 👍

Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: gitdallas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ffda3af into opendatahub-io:main Jun 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants