Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine logic actions for runs on an archived experiment page #2873

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Jun 3, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-7543

Description

When an experiment is archived, refine the login on the runs page

  1. On the active runs tab, show an empty state
Screenshot 2024-06-03 at 12 32 42 PM
  1. On the archived runs tab, disable the restore button on both the table toolbar and the row actions
Screenshot 2024-06-03 at 12 33 31 PM Screenshot 2024-06-03 at 12 33 46 PM
  1. On the schedules tab, disable the creation button and the status toggle, so the user cannot enable a schedule
Screenshot 2024-06-03 at 12 34 26 PM
  1. The user could duplicate a schedule, but the status will be disabled
  2. Refine the logic on the create runs page, the experiment dropdown for a one-time triggered run will only show active experiments (even if you are under the archived experiment context). Duplicating a run with an archived experiment will not auto-fill any experiment now. Create schedules page is working as previously
Screenshot 2024-06-03 at 12 37 09 PM

How Has This Been Tested?

  1. Create an experiment
  2. Create some runs and schedules using this experiment
  3. Archived this experiment
  4. Verify the active tab is showing an empty state
  5. Verify the restore buttons are disabled on the archived runs tab
  6. Verify the create button and status is disabled on the schedules tab
  7. Try to duplicate an archived run/schedule, and switch between the run/schedule creation page, make sure the experiment selection logic is working fine as mentioned in the description

Test Impact

Added some cypress tests to verify the buttons on the archived experiment runs page.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode
Copy link
Member Author

@yannnz @xianli123 Can you verify the UI changes?

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 94.94949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.10%. Comparing base (3bee930) to head (ce61bac).
Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
+ Coverage   77.44%   78.10%   +0.66%     
==========================================
  Files        1110     1098      -12     
  Lines       23521    23296     -225     
  Branches     5937     5889      -48     
==========================================
- Hits        18215    18195      -20     
+ Misses       5306     5101     -205     
Files Coverage Δ
...c/concepts/pipelines/content/createRun/RunForm.tsx 96.29% <ø> (ø)
...un/contentSections/ProjectAndExperimentSection.tsx 93.33% <100.00%> (+1.02%) ⬆️
...ipelines/content/experiment/ExperimentSelector.tsx 92.30% <100.00%> (+1.98%) ⬆️
...nes/content/pipelineSelector/useCreateSelectors.ts 95.45% <100.00%> (+18.53%) ⬆️
...pelinesDetails/pipeline/PipelineDetailsActions.tsx 100.00% <ø> (ø)
...es/content/tables/experiment/useExperimentTable.ts 100.00% <100.00%> (ø)
...ines/content/tables/pipeline/PipelinesTableRow.tsx 90.74% <ø> (ø)
...es/content/tables/pipelineRun/PipelineRunTable.tsx 96.38% <100.00%> (+0.18%) ⬆️
...content/tables/pipelineRun/PipelineRunTableRow.tsx 92.50% <100.00%> (-0.84%) ⬇️
...bles/pipelineRunJob/PipelineRunJobTableToolbar.tsx 69.23% <ø> (-10.77%) ⬇️
... and 14 more

... and 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bee930...ce61bac. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. looking at it live now

@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Jun 5, 2024

The create schedule experiment selector shows archived experiments when the experiment it was created from was active

@Gkrumbach07
Copy link
Member

This looks good. i tested it live and the flows work as expected

/lgtm

@Gkrumbach07
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2d7ae79 into opendatahub-io:main Jun 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants