-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine logic actions for runs on an archived experiment page #2873
Refine logic actions for runs on an archived experiment page #2873
Conversation
@yannnz @xianli123 Can you verify the UI changes? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2873 +/- ##
==========================================
+ Coverage 77.44% 78.10% +0.66%
==========================================
Files 1110 1098 -12
Lines 23521 23296 -225
Branches 5937 5889 -48
==========================================
- Hits 18215 18195 -20
+ Misses 5306 5101 -205
... and 46 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good. looking at it live now
...end/src/concepts/pipelines/content/createRun/contentSections/ProjectAndExperimentSection.tsx
Show resolved
Hide resolved
The create schedule experiment selector shows archived experiments when the experiment it was created from was active |
This looks good. i tested it live and the flows work as expected /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: https://issues.redhat.com/browse/RHOAIENG-7543
Description
When an experiment is archived, refine the login on the runs page
How Has This Been Tested?
Test Impact
Added some cypress tests to verify the buttons on the archived experiment runs page.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main