Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mlmd service prefix #2877

Conversation

Gkrumbach07
Copy link
Member

closes: https://issues.redhat.com/browse/RHOAIENG-7526

Description

Updated the pod name prefix for mlmd due to a backend change.

How Has This Been Tested?

  • create a pipeline server
  • go to executions table list and verify you dont get a error page There was an issue loading executions. Unknown Content-type received.

Test Impact

no tests impacted, backend change

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Port-forwarding works as expected and executions table renders without error page.

@christianvogt
Copy link
Contributor

@Gkrumbach07 please update the Makefile as well:

'oc port-forward -n ${NAMESPACE} svc/ds-pipeline-metadata-envoy-${DSPA_NAME} ${METADATA_ENVOY_SERVICE_PORT}:8443' \

@Gkrumbach07
Copy link
Member Author

/approve

thanks for the reviews yall!

Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07, jenny-s51

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07
Copy link
Member Author

/hold

adding makefile change quick

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Jun 4, 2024
@Gkrumbach07 Gkrumbach07 force-pushed the task/RHOAIENG-7526-update-pipeline-metadata-envoy-service-pod-name branch from 5687615 to 054549e Compare June 4, 2024 22:00
@openshift-ci openshift-ci bot removed the lgtm label Jun 4, 2024
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added the approved label Jun 4, 2024
@Gkrumbach07
Copy link
Member Author

Gkrumbach07 commented Jun 4, 2024

Adding the labels back to get this to merge for nightlies. Actual changes were reviewed, however i needed to update the makefile as well so lgtm was lost

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.18%. Comparing base (b33db83) to head (054549e).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2877      +/-   ##
==========================================
+ Coverage   78.16%   78.18%   +0.02%     
==========================================
  Files        1101     1101              
  Lines       23421    23438      +17     
  Branches     5902     5907       +5     
==========================================
+ Hits        18307    18326      +19     
+ Misses       5114     5112       -2     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33db83...054549e. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 2b19ddb into opendatahub-io:main Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants