Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted dead code in second pass #2881

Merged

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented Jun 5, 2024

Closes: RHOAIENG-2497

Description

Deleting dead code to improve overall code quality

How Has This Been Tested?

npm run test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@rsun19
Copy link
Contributor Author

rsun19 commented Jun 5, 2024

@christianvogt

confirming that checkModelMeshFailureStatus in src/pages/modelServing/utils.ts:301:14 should be deleted right?

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (ac0fc61) to head (a8b1d88).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
+ Coverage   78.75%   78.87%   +0.12%     
==========================================
  Files        1101     1104       +3     
  Lines       23440    23460      +20     
  Branches     5907     5916       +9     
==========================================
+ Hits        18459    18505      +46     
+ Misses       4981     4955      -26     
Files Coverage Δ
frontend/src/api/trustyai/k8s.ts 100.00% <ø> (+11.76%) ⬆️
frontend/src/api/trustyai/rawTypes.ts 100.00% <ø> (ø)
...delRegistry/context/useModelRegistryNamespaceCR.ts 71.87% <100.00%> (ø)
...end/src/concepts/pipelines/content/tables/utils.ts 76.19% <ø> (+2.85%) ⬆️
frontend/src/concepts/topology/utils.ts 93.33% <ø> (-0.42%) ⬇️
frontend/src/pages/modelServing/screens/const.ts 100.00% <ø> (ø)
...nd/src/pages/modelServing/screens/metrics/const.ts 91.30% <ø> (-1.29%) ⬇️
frontend/src/pages/modelServing/utils.ts 87.76% <ø> (+1.75%) ⬆️
...es/pipelines/global/experiments/artifacts/utils.ts 100.00% <ø> (+63.63%) ⬆️
frontend/src/types.ts 100.00% <ø> (ø)

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0fc61...a8b1d88. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
@rsun19
Copy link
Contributor Author

rsun19 commented Jun 6, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 2f76c11 into opendatahub-io:main Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants