Add error state when pipeline version is deleted

[ppadti]

Closes: RHOAIENG-6683

Description

This PR aims to add error state in pipeline run details page when pipeline version is deleted.

How Has This Been Tested?

1. create a pipeline
2. create a run for that.
3. delete pipeline version of that run.
4. From Experiments and run page open pipeline run details page.
5. It will show the error state on run graph and pipeline spec tab. Also in details tab, "No pipeline version" will be mentioned for pipeline version property.

Test Impact

Added cypress test.

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[ppadti]

/retest

[ppadti]

cc @yannnz

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (520c92a) to head (8499279).
Report is 56 commits behind head on main.

❗ Current head 8499279 differs from pull request most recent head a242515

Please upload reports for the commit a242515 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2915      +/-   ##
==========================================
+ Coverage   78.52%   78.56%   +0.04%     
==========================================
  Files        1139     1139              
  Lines       24171    24176       +5     
  Branches     6099     6101       +2     
==========================================
+ Hits        18980    18994      +14     
+ Misses       5191     5182       -9     

Files	Coverage Δ
...ipelinesDetails/pipelineRun/PipelineRunDetails.tsx	82.14% <100.00%> (+1.78%)	⬆️
...linesDetails/pipelineRun/PipelineRunTabDetails.tsx	95.23% <100.00%> (+0.50%)	⬆️
...rontend/src/concepts/topology/PipelineTopology.tsx	95.45% <100.00%> (+0.71%)	⬆️

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520c92a...a242515. Read the comment docs.

[dpanshug]

ApplicationsPage is a global component, so rather than adding Pipeline specific props to it, you should handle the versionLoaded condition inside the PipelineRunDetails.
See the suggestions below to implement this.

[dpanshug]

LGTM, just a small change

[dpanshug]

After this if we redirect to the runs of a deleted pipeline version, we see the loading state of the pipeline in the breadcrumb. How should we handle this? @Gkrumbach07 @yannnz

[yannnz]

@dpanshug I think this is a bug. We don't need to show pipeline name in the breadcrumb, since the path to this page is from Selected Experiment to this selected Run. I remeber @DaoDaoNoCode is working on fix it.

[ppadti]

Hi @ppadti , the Pipeline spec tab has been missed.

@Gkrumbach07 to display Pipeline spec tab, we need to have version. https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetails.tsx#L173
Is it okay if we don't display that when the pipeline version is deleted or you want me to change the condition there.

[yannnz]

@ppadti I would suggest to follow the same design pattern for Run graph tab since we are not able to get the data of the spec for a deleted pipeline: displaying error message as the statement.

[yannnz]

Hi @kaedward , could you help to review the error state for the Pipeline spec tab? In the mock, I just updated the "Run pipeline graph" to "Run pipeline spec".

[kaedward]

@yannnz, I think I made a suggestion for the run graph message, but reading it back now, I don't think it's super clear because "error loading BLANK" implies that the info can be loaded if an action is taken. If the item has been deleted, the info will never be available to load. So what do you think of these alternate messages?

"Pipeline run graph unavailable
The pipeline version that this run graph belongs to has been deleted."

"Pipeline spec unavailable
The pipeline version that this pipeline spec belongs to has been deleted."

[yannnz]

Thanks @kaedward , sounds good to me.

@yannnz, I think I made a suggestion for the run graph message, but reading it back now, I don't think it's super clear because "error loading BLANK" implies that the info can be loaded if an action is taken. If the item has been deleted, the info will never be available to load. So what do you think of these alternate messages?

"Pipeline run graph unavailable The pipeline version that this run graph belongs to has been deleted."

"Pipeline spec unavailable The pipeline version that this pipeline spec belongs to has been deleted."

[ppadti]

Thanks @kaedward , sounds good to me.

@yannnz, I think I made a suggestion for the run graph message, but reading it back now, I don't think it's super clear because "error loading BLANK" implies that the info can be loaded if an action is taken. If the item has been deleted, the info will never be available to load. So what do you think of these alternate messages?
"Pipeline run graph unavailable The pipeline version that this run graph belongs to has been deleted."
"Pipeline spec unavailable The pipeline version that this pipeline spec belongs to has been deleted."

thanks @kaedward @yannnz

[ppadti]

@yannnz I have updated the PR and screenshots. Please take a look.

[yannnz]

Looks good to me.

[dpanshug]

Works fine, i can see the error message when the version is deleted.

/lgtm

[Gkrumbach07]

this looks good

/approve

[dpanshug]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dpanshug, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [Gkrumbach07]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment