Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for public routes in kserve #2924

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Jun 18, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-6651

Description

Add support for public/private routes in kserve

Screenshot 2024-07-17 at 16 07 27 Screenshot 2024-07-17 at 16 07 14

How Has This Been Tested?

  1. Install ODH Operator 2.14 (needed for the changes in kserve controller)
  2. Create a new project
  3. Deploy a single model server without a public route
  4. Check that the internal route points to the right service
  5. Now edit the deployment and make it public
  6. Check that you end up getting a url

Test Impact

Added integration tests and unit test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux lucferbux added the do-not-merge/work-in-progress This PR is in WIP state label Jun 18, 2024
@lucferbux lucferbux force-pushed the rhoaieng-6651 branch 4 times, most recently from 53e0a02 to 5f5afbe Compare June 18, 2024 17:13
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.51%. Comparing base (408cb31) to head (5f5afbe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2924      +/-   ##
==========================================
- Coverage   78.53%   78.51%   -0.02%     
==========================================
  Files        1139     1139              
  Lines       24171    24187      +16     
  Branches     6099     6110      +11     
==========================================
+ Hits        18982    18991       +9     
- Misses       5189     5196       +7     
Files Coverage Δ
frontend/src/api/k8s/inferenceServices.ts 98.75% <100.00%> (+0.10%) ⬆️
frontend/src/k8sTypes.ts 100.00% <ø> (ø)
...erving/screens/global/InferenceServiceEndpoint.tsx 100.00% <100.00%> (ø)
...screens/projects/kServeModal/ManageKServeModal.tsx 92.23% <ø> (ø)
...d/src/pages/modelServing/screens/projects/utils.ts 93.98% <100.00%> (+0.06%) ⬆️
...g/screens/global/InternalServicePopoverContent.tsx 73.33% <57.14%> (-15.56%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408cb31...5f5afbe. Read the comment docs.

@lucferbux lucferbux removed the do-not-merge/work-in-progress This PR is in WIP state label Jul 9, 2024
@lucferbux lucferbux changed the title [WIP] Add support for public routes in kserve Add support for public routes in kserve Jul 9, 2024
@lucferbux
Copy link
Contributor Author

@vconzola Just pinging you to let you know no UX changes were required, we implemented the same UI as modlemesh. (see screenshots)

@lucferbux lucferbux force-pushed the rhoaieng-6651 branch 2 times, most recently from b04b6c9 to c5cc583 Compare July 10, 2024 14:38
@vconzola
Copy link

Thanks for the update @lucferbux. I'm a bit surprised to see there's no "copy to clipboard" icon on the Route URL in the popover. Isn't that part of the modelmesh UI?

@lucferbux
Copy link
Contributor Author

Thanks for the update @lucferbux. I'm a bit surprised to see there's no "copy to clipboard" icon on the Route URL in the popover. Isn't that part of the modelmesh UI?

Yeah, updated with ClipboardCopy, we never had those on the mockups, included it in the PR for KServe and ModelMesh.

Screenshot 2024-07-17 at 16 07 14 Screenshot 2024-07-17 at 16 07 27

@lucferbux
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit c0cacad into opendatahub-io:main Jul 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants