-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for public routes in kserve #2924
Add support for public routes in kserve #2924
Conversation
53e0a02
to
5f5afbe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
==========================================
- Coverage 78.53% 78.51% -0.02%
==========================================
Files 1139 1139
Lines 24171 24187 +16
Branches 6099 6110 +11
==========================================
+ Hits 18982 18991 +9
- Misses 5189 5196 +7
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@vconzola Just pinging you to let you know no UX changes were required, we implemented the same UI as modlemesh. (see screenshots) |
b04b6c9
to
c5cc583
Compare
Thanks for the update @lucferbux. I'm a bit surprised to see there's no "copy to clipboard" icon on the Route URL in the popover. Isn't that part of the modelmesh UI? |
Yeah, updated with ClipboardCopy, we never had those on the mockups, included it in the PR for KServe and ModelMesh. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gitdallas, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Closes https://issues.redhat.com/browse/RHOAIENG-6651
Description
Add support for public/private routes in kserve
How Has This Been Tested?
Test Impact
Added integration tests and unit test.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main