Add custom container size to workbenches table

[manaswinidas]

Closes: https://issues.redhat.com/browse/RHOAIENG-578

Description

When an administrator updates the notebook sizes, the container size now changes to Custom instead of Unknown.

Workbenches table(not expanded):

Workbenches table(expanded):

Edit workbenches for deleted notebook sizes(expanded):

How Has This Been Tested?

1. Create a workbench with any container size
2. Go to console and update the notebookSizes in OdhDashboardConfig(for example)
3. Go to your Workbenches table on your dashboard and see Custom in the Container size. Expand the table row and see limits and requests.
4. Edit this workbench > now you should see a selected "Keep custom size" option in the expanded Container size dropdown, along with its limits and requests.
5. Try editing the workbench name while keeping others intact. The container size should still be "Custom" in the workbenches table after updating the workbench name.

Test Impact

Added e2e test

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main.

[manaswinidas]

@kywalker-rh Is there a need to state the resource limits and requests below Custom. According to the pinned comment, "the row can be expanded to see the value at play"

For example,

[kywalker-rh]

@manaswinidas It would be helpful for the user to see what the limits and requests are, but as it states in the other comment, this can be shown when the row is expanded.

[manaswinidas]

@manaswinidas It would be helpful for the user to see what the limits and requests are, but as it states in the other comment, this can be shown when the row is expanded.

@kywalker-rh Yes, this is there but the limits and requests are not in the expanded row now that this container size is deleted. You can check this in the screen recording attached in the PR description.

I have added screenshots to show the container size dropdown for this "Custom" state. Can you check them when you have time?

As shown in the screenshot, I'm adding "Custom" as the first option in the dropdown and it doesn't show limits and requests in the option description coz it's all deleted. If I show them, it will look something like this:

Let me know if the screenshots and screen recording look fine.

[andrewballantyne]

@manaswinidas can we not show whatever is in the notebook? It's only on edit we show custom, right?

[manaswinidas]

@andrewballantyne

can we not show whatever is in the notebook?

Are you referring to the limits and requests? We are fetching the sizes directly from dashboardConfig and then running a find, the size referred to here isn't there in dashboardConfig anymore and the size we are getting from useNotebookDeploymentSize is also null.

It's only on edit we show custom, right?

Oh yes, missed it. Updated to show "Custom" dropdown option only on Edit.

@kywalker-rh Also, is there a need to change the content in this alert?

[dpanshug]

When creating a new workbench the alert pops up.

Screen.Recording.2024-07-03.at.2.16.02.PM.mov

[manaswinidas]

@dpanshug fixed!

[kywalker-rh]

@kywalker-rh Yes, this is there but the limits and requests are not in the expanded row now that this container size is deleted. You can check this in the screen recording attached in the PR description.

@manaswinidas I'm sorry I misunderstood what you were asking before. With more context I'm okay moving forward as is.

[manaswinidas]

@kywalker-rh We now have the limits and requests in the expanded row. The screenshots and screen recording have been updated in the PR description.

[dpanshug]

Just a small nit, otherwise lgtm

[emilys314]

I verified the changes in this branch on my cluster, everything checks out functionality wise:

Screenshots

[andrewballantyne]

/uncc
/unassign

Christian is on the review side of things now. I'll step out. Tag me if you need me.

Stale

[manaswinidas]

@christianvogt made the requested changes and the build passed.

[christianvogt]

Retested the previous failing scenarios I noted in comments and they are now working correctly.

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, dpanshug, gitdallas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment