Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-7794]: Use different colors for the ROC curve legend #2957

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Jun 26, 2024

https://issues.redhat.com/browse/RHOAIENG-7794

Description

Previously in pipelines compare runs we would compare many ROC curves in one graph by using different shades of blue, but per the PF recommendation we should instead be corresponding each run with one of the available base colors.

Before
Screenshot 2024-06-26 at 2 07 56 PM
Screenshot 2024-06-26 at 2 08 01 PM

After
Screenshot 2024-06-26 at 1 41 29 PM
Screenshot 2024-06-26 at 1 41 35 PM

How Has This Been Tested?

Compare runs that have all metrics. Use the following pipeline
Pipeline metrics-visualization-pipeline.yaml.zip

Test Impact

N/A, color change only

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@Gkrumbach07
Copy link
Member

/lgtm

@Gkrumbach07
Copy link
Member

waiting on 1 more review @jenny-s51

@Gkrumbach07
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, jpuzz0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5adcba7 into opendatahub-io:main Jul 2, 2024
6 checks passed
@jenny-s51 jenny-s51 deleted the RHOAIENG-7794 branch July 2, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants