-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-4334] 'Job' Name (in code) alignment #2961
Conversation
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts
Show resolved
Hide resolved
3e03519
to
b3802ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
going to test live to make sure things still work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
tested job flows and things work as expected /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-4334
Description
Renamed "Job" to "Recurring run"
How Has This Been Tested?
Check the codebase to ensure that all instances of 'job' are either replaced with 'recurring run' or that the corresponding function/type is marked as deprecated.
Also, run and check all the functionality of pipelines in dashboard to ensure everything is working as expected.
Test Impact
No tests added, modified the previous tests to accommodate the change.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main