Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make proxy service have upload byte limit #2965

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Jun 28, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-8080

Description

When uploading to the Pipeline Service, it does not limit the request on the bytes sent. this issue is been currently addressed on client side for pipeline in this PR #2874
To overall limit the upload body limit , changes are been done in backend side

Screenshot 2024-06-28 at 5 17 15 PM

How Has This Been Tested?

  1. Create a file of > 1 mib ( to do this run openssl rand -hex 25000000 > mb-50.yaml)
    2.Undo the changes made in this PR Add Pipeline Upload filesize limit #2874
  2. Go to Pipeline Page and click on import pipeline
  3. Import the created file
  4. See if error is thrown

Test Impact

No test impacted

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit cdf0d85 into opendatahub-io:main Jul 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants