feat(mr settings): permissions table #2969

gitdallas · 2024-06-30T03:11:52Z

Closes: https://issues.redhat.com/browse/RHOAIENG-6636

Description

Add model registry settings > permissions page. Factored out components from ProjectSharing (project permissions).

How Has This Been Tested?

Ran through creating/editing/deleting rolebindings for users/groups in model registries, also tested project permissions since that was factored out.

Test Impact

added cypress testing for the new page

Request review criteria:

make sure that you can create/edit/delete user/group rolebindings for model registries and that project permissions isn't broken

Self checklist (all need to be checked):

The developer has manually tested the changes and verified that the changes work
Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

Included any necessary screenshots or gifs if it was a UI change.
Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

The developer has tested their solution on a cluster by using the image produced by the PR to main

gitdallas · 2024-07-02T12:48:34Z

i just noticed the ? icon for the default group permission in the new mock and if i aggregate the previous mocks i need it to have a tooltip that says "This group is created by default. You can add users to this group via the API."

so i'll add that

mturley

Really good stuff @gitdallas . I have a couple of things, hopefully it won't be too bad to address.

frontend/src/__mocks__/mockRoleBindingK8sResource.ts

frontend/src/api/k8s/roleBindings.ts

frontend/src/concepts/roleBinding/RoleBindingPermissions.tsx

frontend/src/concepts/roleBinding/RoleBindingPermissionsTableRow.tsx

frontend/src/concepts/roleBinding/utils.ts

frontend/src/k8sTypes.ts

frontend/src/pages/modelRegistrySettings/ModelRegistriesPermissions.tsx

frontend/src/pages/modelRegistrySettings/useRoleBindings.ts

mturley · 2024-07-03T16:27:36Z

@gitdallas while you're in here, can you actually also please look at the DeleteModelRegistryModal and replace the placeholder text "TODO: group here" with ${mr.metadata.name}-users? You can just inline it and get rid of the defaultPermissionsGroup variable. I thought we'd have to fetch something to look that up but since we're making the naming convention assumption here, we can use it there too.

mturley · 2024-07-03T18:16:25Z

Looks like the test failure is just Prettier

mturley

Tested and it's working well for me on the MR side, and the failures on the project side are caused by the lines I comment on below. Also a couple more minor nits. Otherwise all the changes LGTM.

frontend/src/api/k8s/roleBindings.ts

frontend/src/concepts/roleBinding/RoleBindingPermissionsTable.tsx

frontend/src/concepts/roleBinding/RoleBindingPermissionsTableRow.tsx

frontend/src/concepts/roleBinding/RoleBindingPermissionsTableRowAdd.tsx

lucferbux

Ok I agree on @mturley changes and I added one more thing to do. Rest lgtm

frontend/src/api/k8s/roleBindings.ts

gitdallas · 2024-07-08T11:43:08Z

failing test seems unrelated (compareRuns graph)

lucferbux

ok, just a nit, rest of code looks great, once you have that change we can merge it!

frontend/src/pages/modelRegistrySettings/ModelRegistriesPermissions.tsx

lucferbux

/lgtm

openshift-ci · 2024-07-09T12:01:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [lucferbux]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lucferbux · 2024-07-09T13:39:13Z

mmmm weird, some pipeline test has failed. let me try and retest it
/retest

gitdallas · 2024-07-09T13:41:08Z

@lucferbux - yea, mentioned that #2969 (comment)

seems consistent

Signed-off-by: gitdallas <[email protected]> auto lint fixes Signed-off-by: gitdallas <[email protected]> fix lints Signed-off-by: gitdallas <[email protected]> some cleanup Signed-off-by: gitdallas <[email protected]> tests for mr permissions Signed-off-by: gitdallas <[email protected]>

Signed-off-by: gitdallas <[email protected]>

lucferbux · 2024-07-09T14:36:55Z

/lgtm

gitdallas requested a review from mturley June 30, 2024 03:11

openshift-ci bot requested review from alexcreasy and dpanshug June 30, 2024 03:12

gitdallas force-pushed the feat/6636-mr-rbac-users branch from 0066695 to f37ed0c Compare June 30, 2024 03:16

mturley requested changes Jul 2, 2024

View reviewed changes

openshift-ci bot assigned mturley Jul 2, 2024

gitdallas force-pushed the feat/6636-mr-rbac-users branch from f37ed0c to 9836d03 Compare July 2, 2024 19:36

gitdallas force-pushed the feat/6636-mr-rbac-users branch from 9836d03 to bbc9a6f Compare July 3, 2024 18:59

mturley reviewed Jul 3, 2024

View reviewed changes

lucferbux requested changes Jul 4, 2024

View reviewed changes

frontend/src/api/k8s/roleBindings.ts Outdated Show resolved Hide resolved

frontend/src/api/k8s/roleBindings.ts Outdated Show resolved Hide resolved

openshift-ci bot assigned lucferbux Jul 4, 2024

gitdallas force-pushed the feat/6636-mr-rbac-users branch 3 times, most recently from 36049a1 to c7a782b Compare July 7, 2024 13:54

gitdallas requested review from mturley and lucferbux July 8, 2024 11:51

lucferbux requested changes Jul 9, 2024

View reviewed changes

frontend/src/pages/modelRegistrySettings/ModelRegistriesPermissions.tsx Outdated Show resolved Hide resolved

gitdallas force-pushed the feat/6636-mr-rbac-users branch from c7a782b to ff4a46b Compare July 9, 2024 11:56

lucferbux approved these changes Jul 9, 2024

View reviewed changes

openshift-ci bot added the lgtm label Jul 9, 2024

openshift-ci bot added the approved label Jul 9, 2024

gitdallas added 2 commits July 9, 2024 09:36

refactoring around some type consolidation

5ebf3ea

Signed-off-by: gitdallas <[email protected]>

gitdallas added 2 commits July 9, 2024 09:36

add owner ref to mr users and groups

4bacfab

Signed-off-by: gitdallas <[email protected]>

use mr cr for rb owner

d29d5e1

Signed-off-by: gitdallas <[email protected]>

gitdallas force-pushed the feat/6636-mr-rbac-users branch from ff4a46b to d29d5e1 Compare July 9, 2024 14:36

openshift-ci bot removed the lgtm label Jul 9, 2024

openshift-ci bot added the lgtm label Jul 9, 2024

openshift-merge-bot bot merged commit c29e3f0 into opendatahub-io:main Jul 9, 2024
6 checks passed

gitdallas deleted the feat/6636-mr-rbac-users branch July 9, 2024 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mr settings): permissions table #2969

feat(mr settings): permissions table #2969

gitdallas commented Jun 30, 2024

gitdallas commented Jul 2, 2024

mturley left a comment

mturley commented Jul 3, 2024 •

edited

Loading

mturley commented Jul 3, 2024

mturley left a comment •

edited

Loading

lucferbux left a comment

gitdallas commented Jul 8, 2024

lucferbux left a comment

lucferbux left a comment

openshift-ci bot commented Jul 9, 2024

lucferbux commented Jul 9, 2024

gitdallas commented Jul 9, 2024

lucferbux commented Jul 9, 2024

feat(mr settings): permissions table #2969

feat(mr settings): permissions table #2969

Conversation

gitdallas commented Jun 30, 2024

Description

How Has This Been Tested?

Test Impact

Request review criteria:

gitdallas commented Jul 2, 2024

mturley left a comment

Choose a reason for hiding this comment

mturley commented Jul 3, 2024 • edited Loading

mturley commented Jul 3, 2024

mturley left a comment • edited Loading

Choose a reason for hiding this comment

lucferbux left a comment

Choose a reason for hiding this comment

gitdallas commented Jul 8, 2024

lucferbux left a comment

Choose a reason for hiding this comment

lucferbux left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 9, 2024

lucferbux commented Jul 9, 2024

gitdallas commented Jul 9, 2024

lucferbux commented Jul 9, 2024

mturley commented Jul 3, 2024 •

edited

Loading

mturley left a comment •

edited

Loading