-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-4702] Improve unique naming for runs and versions in pipelines #3008
Conversation
6c22045
to
462032d
Compare
frontend/src/concepts/pipelines/content/import/PipelineImportModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/import/PipelineImportModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/import/PipelineVersionImportModal.tsx
Outdated
Show resolved
Hide resolved
Added comments. Biggest thing is that we dont want to be doing a recursive fetching resources. This is the same reason why we dont have the feature for "delete a pipeline and it deletes all the versions too" |
929be1e
to
722e3c5
Compare
3231065
to
d61f557
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
tested, debounce works, does not block submit
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Closes: RHOAIENG-4702
Description
How Has This Been Tested?
Manual testing, and updated existing tests to verify the existence of the duplicate name helper text.
Test Impact
Creation of runs, schedules, and importing of pipelines and versions.
How to test
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main