Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the DS project list toggle #3018

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Jul 19, 2024

Closes: RHOAIENG-9576

Description

This PR aims to remove the DS project list toggle.

Screenshot from 2024-07-22 14-31-34

How Has This Been Tested?

In DS list page, we will not be having a toggle to switch projects.

Test Impact

Updated cypress test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti
Copy link
Contributor Author

ppadti commented Jul 19, 2024

@kywalker-rh @xianli123 could you please take a look the UI changes?
One quick question, In project list page we had a image beside DS project name. I removed it in this PR. I just wanted to know that Is it fine to have list of project without that image or you prefer to have it for all the projects. Let me know your thoughts on this.

screenshot of the image I am talking about for ref:

Screenshot from 2024-07-19 18-21-47

@andrewballantyne
Copy link
Member

@kywalker-rh @xianli123 could you please take a look the UI changes? One quick question, In project list page we had a image beside DS project name. I removed it in this PR. I just wanted to know that Is it fine to have list of project without that image or you prefer to have it for all the projects. Let me know your thoughts on this.

screenshot of the image I am talking about for ref:

Screenshot from 2024-07-19 18-21-47

I'll step in here 🙂 Yes, we do need to get rid of the identifier. We are looking to get so far away from this concept of "Data Science Projects are different" that we are even RFE-ing a rename of this page to just Projects. So definitely get rid of it 👍

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested locally! Awesome to finally have this weird toggle gone.

Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d47fa7a into opendatahub-io:main Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants