Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-7943] Navigate to pipeline details on import #3026

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jul 22, 2024

https://issues.redhat.com/browse/RHOAIENG-7943

Description

Redirect to the pipeline details page after a pipeline is created via URL or uploaded using a yaml file.

How Has This Been Tested?

Manually tested & updated pipeline creation cypress tests to verify the user is redirected to the appropriate URL.

How to test

Import a pipeline using a yaml file and a URL, verify both methods lead to being redirected to the pipeline version details page.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 22, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7943-pipeline-details-after-upload branch 3 times, most recently from 192dd0e to aede80f Compare July 22, 2024 19:49
@Gkrumbach07
Copy link
Member

can you rebase your changes so the files changes are correct

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7943-pipeline-details-after-upload branch 2 times, most recently from 64a87ed to aa59d2b Compare July 24, 2024 20:06
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7943-pipeline-details-after-upload branch from aa59d2b to d9359a6 Compare July 24, 2024 20:08
@jpuzz0 jpuzz0 changed the title WIP [RHOAIENG-7943] Navigate to pipeline details on import [RHOAIENG-7943] Navigate to pipeline details on import Jul 24, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jul 24, 2024
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 979f9ba into opendatahub-io:main Jul 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants