Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition of ready and done #3031

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

jessiehuff
Copy link
Contributor

@jessiehuff jessiehuff commented Jul 24, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-10271

Description

We need our Definition of Done and Definition of Ready docs moved into markdown files in the docs folder and our contribution markdown file updated to point at those

How Has This Been Tested?

N/A (Non-code change)

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the perspective of someone new who just went through all of the dev setup and contributing docs: LGTM

docs/definition-of-done.md Outdated Show resolved Hide resolved
docs/definition-of-ready.md Outdated Show resolved Hide resolved

## Jira status
- Screenshots of the updated UI should be captured in the jira history/comments (or link to GitHub Pull Request with these screenshots) to illustrate work that was completed.
- All related UX stories are closed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgutride This should be a DoR -- we moved away as far as we could from parallel work, I think we need this updated.

@andrewballantyne
Copy link
Member

@jessiehuff please update the text from @Griffin-Sullivan, we can look to merge this and iterate as needed.

@openshift-ci openshift-ci bot added the lgtm label Jul 25, 2024
Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d0de08d into opendatahub-io:main Jul 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants